Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Studio Explorer boilerplate HTML #526

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Add the Studio Explorer boilerplate HTML #526

merged 4 commits into from
Feb 23, 2022

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Feb 22, 2022

close #68

abernix
abernix approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one potentially important consideration that should be resolved before merging around the registered introspection query, and a couple text tweaks, but I can confirm that this looks and works great otherwise! Nice job!

apollo-router/resources/index.html Outdated Show resolved Hide resolved
apollo-router/resources/index.html Outdated Show resolved Hide resolved
apollo-router/resources/index.html Outdated Show resolved Hide resolved
apollo-router/resources/index.html Show resolved Hide resolved
bnjjj and others added 3 commits February 23, 2022 16:50
@bnjjj
Add the Studio Explorer boilerplate HTML
ca0b00f 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj @abernix
Apply suggestions from code review
53adf49 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
@bnjjj
add well known introspection queries
e098ec4 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj force-pushed the bnjjj/fix_68 branch 2 times, most recently from 817f31e to c9d7638 Compare February 23, 2022 15:55
@bnjjj
add well known introspection queries
c3c3741 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj merged commit 96faaa7 into main Feb 23, 2022
@bnjjj bnjjj deleted the bnjjj/fix_68 branch February 23, 2022 15:56
@abernix abernix mentioned this pull request Feb 23, 2022
Merged
@abernix abernix linked an issue Feb 23, 2022 that may be closed by this pull request
Redirect to Studio doesn't preserve HTTP scheme #380
Closed
This was referenced Feb 23, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

@abernix abernix abernix approved these changes

@Geal Geal Geal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect to Studio doesn't preserve HTTP scheme Studio Explorer Boilerplate HTML
4 participants
@bnjjj @Geal @abernix @o0Ignition0o